findepi commented on issue #13470: URL: https://github.com/apache/datafusion/issues/13470#issuecomment-2538400316
thank you @Omega359 for your work on this! > The result is that everything runs however a LOT of queries are skipped for DF for various reasons. that's totally understandable! what about having them with `query error msg` instead of skip, so that they act as "executable todo" and thus we don't need to remember to find and enable tests when corresponding functionality is fixed? > Because of the format differences between the slt files in DF vs sqlite a custom version of sqllogictest dependency is required. i know you mentioned this earlier (https://github.com/apache/datafusion/issues/13470#issuecomment-2518423885), but i unfortunately don't know what the difference is. How big it is? Can we avoid custom dependency with eg a regexp replace? cc @gliga -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
