alamb commented on code in PR #13372:
URL: https://github.com/apache/datafusion/pull/13372#discussion_r1882165666
##########
datafusion/sqllogictest/test_files/expr.slt:
##########
@@ -1100,24 +1100,23 @@ SELECT date_part('microsecond', timestamp
'2020-09-08T12:00:12.12345678+00:00')
query error DataFusion error: Internal error: unit Nanosecond not supported
SELECT date_part('nanosecond', timestamp '2020-09-08T12:00:12.12345678+00:00')
-
query I
SELECT date_part('second', '2020-09-08T12:00:12.12345678+00:00')
----
12
query I
-SELECT date_part('millisecond', '2020-09-08T12:00:12.12345678+00:00')
+SELECT date_part('second', timestamp '2020-09-08T12:00:12.12345678+00:00')
Review Comment:
are these test changes still needed?
From my perspective as long as this PR doesn't change the ability to use a
string as an argument to a function that requires a timestamp, it is a good
change to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
