jayzhan211 commented on PR #13372: URL: https://github.com/apache/datafusion/pull/13372#issuecomment-2539065729
> Thank you @jayzhan211 -- I know this has been a long process. Sorry for the slower pace but I think as DataFusion attempts to be more stable, more attention is warranted for potential changes. > > Other than the string coercion (I left a question) this PR looks good to me given your comment on [#13732 (comment)](https://github.com/apache/datafusion/pull/13732#issuecomment-2538830582) > > ❤️ Thanks again I'm also thinking about the comment above about whether to differentiate timestamp timezone or not. Given that we already have NativeType::Timestamp for differentiate with tz or without, I still don't think it is a good idea to add another abstraction in TypeSignatureClass. For date_bin that takes 2 args, I think using `TypeSignatureClass::Native()` might be a better idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
