MartinSahlen commented on code in PR #1602:
URL: 
https://github.com/apache/datafusion-sqlparser-rs/pull/1602#discussion_r1884221402


##########
tests/sqlparser_bigquery.rs:
##########
@@ -2097,6 +2097,14 @@ fn test_bigquery_create_function() {
             "REMOTE WITH CONNECTION us.myconnection ",
             "OPTIONS(a = [1, 2])",
         ),
+        // Templated
+        concat!(
+            "CREATE OR REPLACE TEMPORARY FUNCTION ",
+            "my_function(param1 ANY TYPE) ",
+            "AS (",
+            "(SELECT 1)",
+            ")",
+        ),

Review Comment:
   Good point, I was in fact doing that but reverted to inlining the test with 
other UDFs. Not being sure what was the preferred pattern but makes sense!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to