MartinSahlen commented on PR #1602: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1602#issuecomment-2542137285
> Thanks @MartinSahlen! The changes look reasonable to me, left a couple minor comments Thanks for the review and suggestions! I have now added the suggested changes and improvements, along with two seperate tests - test that the usage of "ANY TYPE" works in a function definition for BigQuery - test that the usage of the "ANY" type still works as a standalone type to support arbitrary or user-defined types without being restrictive. This also makes a lot of sense as the goal of this codebase is not to provide an opinionated or semantic validating parser. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
