findepi commented on code in PR #13756:
URL: https://github.com/apache/datafusion/pull/13756#discussion_r1884571314
##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -414,7 +415,18 @@ fn get_valid_types(
_ => Ok(vec![vec![]]),
}
}
+
fn array(array_type: &DataType) -> Option<DataType> {
+ match array_type {
Review Comment:
for backwards compat i should keep LargeList so it stays LargeList, will
push shortly
> Aka it doesn't make sense to me that List is treated differently than
LargeList and FixedSizeList
not my invention, it was like this before.
i think the intention is "converge List, LL and FSL into one type... or
maybe two types... to keep UDF impl simpler".
i am not attached to this approach, but i think code may be reliant on that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
