Re: [PR] Fix get_type for higher-order array functions [datafusion]

[via GitHub]

jayzhan211 commented on code in PR #13756:
URL: https://github.com/apache/datafusion/pull/13756#discussion_r1887746446


##########
datafusion/functions-nested/src/extract.rs:
##########
@@ -993,3 +993,84 @@ where
     let data = mutable.freeze();
     Ok(arrow::array::make_array(data))
 }
+
+#[cfg(test)]
+mod tests {
+    use super::array_element_udf;
+    use arrow_schema::{DataType, Field};
+    use datafusion_common::{Column, DFSchema, ScalarValue};
+    use datafusion_expr::expr::ScalarFunction;
+    use datafusion_expr::{cast, Expr, ExprSchemable};
+    use std::collections::HashMap;
+
+    #[test]
+    fn test_array_element_return_type() {
+        let complex_type = DataType::FixedSizeList(

Review Comment:
   > why applying the coercion rules changes the input type in the first place 
(which seems suspicious)
   
   Fixed size list coerced to List
   
   ```rust
       ArrayFunctionSignature::Array => {
           if current_types.len() != 1 {
               return Ok(vec![vec![]]);
           }
   
           array(&current_types[0])
               .map_or_else(|| vec![vec![]], |array_type| 
vec![vec![array_type]])
       }
   
       fn array(array_type: &DataType) -> Option<DataType> {
           match array_type {
               DataType::List(_)
               | DataType::LargeList(_)
               | DataType::FixedSizeList(_, _) => {
                   let array_type = coerced_fixed_size_list_to_list(array_type);
                   Some(array_type)
               }
               _ => None,
           }
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org