korowa commented on code in PR #13751:
URL: https://github.com/apache/datafusion/pull/13751#discussion_r1884970634
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -90,9 +90,6 @@ struct JoinLeftData {
/// Counter of running probe-threads, potentially
/// able to update `visited_indices_bitmap`
probe_threads_counter: AtomicUsize,
- /// Memory reservation that tracks memory used by `hash_map` hash table
- /// `batch`. Cleared on drop.
- _reservation: MemoryReservation,
Review Comment:
In case reservation is not stored in `JoinLeftData`, it'll be dropped right
after `collect_left_input` due to being unneeded anymore. And due to
`MemoryReservation` calls `free` on its
[drop](https://github.com/apache/datafusion/blob/08d3b656d761a8e0d9e7f7c35c7b76cfec00e095/datafusion/execution/src/memory_pool/mod.rs#L333),
it looks like that with this patch, during the whole join execution build side
data will be untracked by memory pool.
So the initial idea of this attribute was to make reservation to live as
long as `JoinLeftData` exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
