jayzhan211 commented on code in PR #13751:
URL: https://github.com/apache/datafusion/pull/13751#discussion_r1884985362
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -90,9 +90,6 @@ struct JoinLeftData {
/// Counter of running probe-threads, potentially
/// able to update `visited_indices_bitmap`
probe_threads_counter: AtomicUsize,
- /// Memory reservation that tracks memory used by `hash_map` hash table
- /// `batch`. Cleared on drop.
- _reservation: MemoryReservation,
Review Comment:
The reason I think this is not an issue is because it only matters when we
run 'collect_left_join', we track the memory and free after the build side is
done. Although, the memory is clean while the hash map is not freed. BUT, since
we don't have expected memory change in the probe stage, the memory is not
helpful for the probe stage. That's why I think this will not cause any issues
if we drop the reservation early.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
