findepi commented on PR #13800: URL: https://github.com/apache/datafusion/pull/13800#issuecomment-2553078463
> I would personally expect a planner to cache lookups in the same way I expect a compiler to optimize away repeated calls to a constant method. Agreed > Is there some functionality, customization or capability we are taking away from engines by doing this here? IIUC, this PR adds new code only, so it's not taking away any capability, and it's also not adding any new behavior. it adds building blocks for a desired behavior to be implemented later > Is there some advantage of having every engine reimplement this pattern? When i said "engine" i meant datafusion core. I would want the core to do what you described as "_expect a planner to cache lookups_" You mean "engines" in plural. How this new code is going to be used? In datafusion and/or elsewhere? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
