andygrove opened a new pull request, #1190: URL: https://github.com/apache/datafusion-comet/pull/1190
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes https://github.com/apache/datafusion-comet/issues/1189 ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> Arrow IPC is overkill for encoding single batches for use in Comet native shuffle. We can implement a more efficient custom serde that is better suited to single batch. This PR currently contains a crude proof-of-concept to demonstrate the potential performance of a custom single-batch serde approach and it shows 3.4x faster writes and ~40% faster reads. The proof-of-concept only supports string arrays so far so we will need to test with other types, including complex types. ## Custom serde benchmarks ``` batch_serde/batch_serde: write_batch_fast time: [2.9048 µs 2.9079 µs 2.9117 µs] batch_serde/batch_serde: read_batch_fast time: [21.030 µs 21.161 µs 21.317 µs] ``` ## Arrow IPC benchmarks ``` batch_serde/batch_serde: write_batch_ipc time: [9.8262 µs 9.9445 µs 10.063 µs] batch_serde/batch_serde: read_batch_ipc time: [30.215 µs 30.469 µs 30.795 µs] ``` ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## How are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
