alamb opened a new pull request, #13887: URL: https://github.com/apache/datafusion/pull/13887
## Which issue does this PR close? - Closes https://github.com/apache/datafusion/issues/13766 ## Rationale for this change The recursive-protect flag was added in https://github.com/apache/datafusion/pull/13778, but when @andygrove tried to disable it in comet, recursive was still enabled. I am not an expert in the crate feature mechanism, but the feature appears to get activated if a downstream crate like comet uses a crate like `datafusion` (the core crate) that passes the feature through ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? 1. Make feature not enabled by default in sub crates 2. Add feature to the datafusion core crate 3. move another stack protection mechanism into a guarded section Here is an example showing how I tested to verify that the feature flagging still works ```shell $ cargo test --features=recursive-protection -p datafusion-common --lib | grep test_large_tree Finished `test` profile [unoptimized + debuginfo] target(s) in 0.08s Running unittests src/lib.rs (target/debug/deps/datafusion_common-3dd7d455d375513b) $ cargo test -p datafusion-common --lib | grep test_large_tree Compiling datafusion-common v43.0.0 (/Users/andrewlamb/Software/datafusion/datafusion/common) Finished `test` profile [unoptimized + debuginfo] target(s) in 1.32s Running unittests src/lib.rs (target/debug/deps/datafusion_common-a4d89ac32a58d472) $ ```` I also verified that the MIRI tests pass on https://github.com/apache/datafusion-comet/pull/1154 with this fix ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
