alamb commented on code in PR #13876:
URL: https://github.com/apache/datafusion/pull/13876#discussion_r1896735651
##########
.github/actions/setup-builder/action.yaml:
##########
@@ -42,6 +42,8 @@ runs:
"${RETRY[@]}" rustup component add rustfmt
- name: Configure rust runtime env
uses: ./.github/actions/setup-rust-runtime
+ - name: Setup Rust cache
+ uses: Swatinem/rust-cache@v2
Review Comment:
Let's keep things simple and remove the attempted caching
I think I may also be somewhat biased as really earler versions of the arrow
and datafusion CI jobs tried to use the caching (not this github action, but
some other one) and we eventually found that due to how picky rust was, it was
almost impossible to get the compiler to re-use the intermediate stuff in
`target` so all the caching was simply wasted.
I also found the same thing in our .circleci jobs in Influx (aka that
caching the target directly was never effetive)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
