alamb commented on PR #13651: URL: https://github.com/apache/datafusion/pull/13651#issuecomment-2561158792
My performance benchmarks show also show now difference ✅ ``` ++ critcmp main 13525_invariant-checking-for-implicit-LP-changes group 13525_invariant-checking-for-implicit-LP-changes main ----- ------------------------------------------------ ---- logical_aggregate_with_join 1.00 1498.7±38.07µs ? ?/sec 1.00 1494.0±18.89µs ? ?/sec logical_select_all_from_1000 1.00 5.3±0.05ms ? ?/sec 1.00 5.3±0.05ms ? ?/sec logical_select_one_from_700 1.00 1169.9±26.47µs ? ?/sec 1.01 1179.5±14.41µs ? ?/sec logical_trivial_join_high_numbered_columns 1.00 1154.9±13.48µs ? ?/sec 1.00 1158.7±16.27µs ? ?/sec logical_trivial_join_low_numbered_columns 1.00 1140.9±18.36µs ? ?/sec 1.00 1140.3±14.97µs ? ?/sec physical_intersection 1.00 2.5±0.02ms ? ?/sec 1.00 2.5±0.02ms ? ?/sec physical_join_consider_sort 1.00 3.3±0.02ms ? ?/sec 1.00 3.3±0.04ms ? ?/sec physical_join_distinct 1.00 1130.5±14.83µs ? ?/sec 1.00 1133.2±15.97µs ? ?/sec physical_many_self_joins 1.01 17.5±0.10ms ? ?/sec 1.00 17.4±0.08ms ? ?/sec physical_plan_clickbench_all 1.00 227.8±1.70ms ? ?/sec 1.01 230.0±3.38ms ? ?/sec ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
