Spaarsh commented on issue #13896: URL: https://github.com/apache/datafusion/issues/13896#issuecomment-2564015089
Okay so I went through the code of git clone command [here](https://github.com/git/git/blob/76cf4f61c87855ebf0784b88aaf737d6b09f504b/builtin/clone.c). I also ran the command and did ```ls``` mid run, revealing that it had made the repo with the original name. When I cancelled the clone command, it simply removed all the contents and the directory as well. The git clone source code has a [```remove_junk``` function](https://github.com/git/git/blob/76cf4f61c87855ebf0784b88aaf737d6b09f504b/builtin/clone.c#L470) for this purpose. And just to clarify, the removal of a downloaded file shall be done only in case of an error or exception since those files won't be usable anyway. I was wondering if there might me similar instances in other parts of our code? Should I make a PR for making this action atomic? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
