Spaarsh commented on issue #13896:
URL: https://github.com/apache/datafusion/issues/13896#issuecomment-2564828095

   I have worked a bit on these lines. I have also added traps that ensure that 
cleanup takes place if the user interrupts the downloads intentionally as well. 
Trying to apply it to other functions as well now. The output is this so far:
   #### For the benchmarks/bench.sh data imdb command:
   
![20241230_012510](https://github.com/user-attachments/assets/a61058b2-7cb3-4aa7-8b6f-1b7b9de0b9cc)
   
   #### For the benchmarks/bench.sh data clickbench_1 command:
   
![20241230_012240](https://github.com/user-attachments/assets/4dc12987-a73c-4632-974b-a52bd434cdf3)
   
   If this looks good enough, should open an issue for this and make a PR? Or 
directly open a PR?
   I have pushed this code to my fork 
[here](https://github.com/apache/datafusion/commit/f558cd9210b0dddedd9ff4f8f97dbc510e22d9e5).
 Suggestions are welcome!
   
   Thanks!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to