akupchinskiy commented on PR #1199: URL: https://github.com/apache/datafusion-comet/pull/1199#issuecomment-2571552288
> Are the partition related changes necessary for this PR? Otherwise, it might be better to reduce the scope to just the `rand()` expression. There is a handful of expressions besides rand() relying on the partition index. All of them implement [nondetermenistic trait]( https://github.com/apache/spark/blob/branch-3.5/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala#L472) providing a hook method to initialize a state before a partition evaluation for spark runtime. Encapsulation-wise, I agree that the scope of the partition exposure should be limited. But I could not find another way to extract it other than making it a part of a planner struct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
