ccciudatu commented on code in PR #13772:
URL: https://github.com/apache/datafusion/pull/13772#discussion_r1903336823
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -438,6 +439,22 @@ pub trait SubstraitConsumer: Send + Sync + Sized {
user_defined_literal.type_reference
)
}
+
+ fn consume_extension_table(
+ &self,
+ extension_table: &ExtensionTable,
+ _schema: &DFSchema,
+ _projection: &Option<MaskExpression>,
+ ) -> Result<LogicalPlan> {
Review Comment:
@Blizzara You are most likely right. My main concern was to make sure the
table name gets propagated for extension tables as well.
As @vbarua suggested, the name can be encoded in the extension payload, but
I found that redundant, possibly because I misread the Substrait spec and
assumed the name already had its reserved place outside the
ExtensionTable::detail, but I'm a lot less convinced about that now.
I'll have a look at the new substrait producer and give it another try,
unless this feature can be fully covered by implenting the Producer/Consumer
traits, in which case I'll probably just close this PR without merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
