andygrove commented on code in PR #1253:
URL: https://github.com/apache/datafusion-comet/pull/1253#discussion_r1909275211
##########
spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala:
##########
@@ -89,6 +89,24 @@ class CometAggregateSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ // based on Spark's SQLWindowFunctionSuite test of the same name
+ test("window function: partition and order expressions") {
+ for (shuffleMode <- Seq("auto", "native", "jvm")) {
+ withSQLConf(CometConf.COMET_SHUFFLE_MODE.key -> shuffleMode) {
+ val df =
+ Seq((1, "a", 5), (2, "a", 6), (3, "b", 7), (4, "b", 8), (5, "c", 9),
(6, "c", 10)).toDF(
+ "month",
+ "area",
+ "product")
+ df.createOrReplaceTempView("windowData")
+ checkSparkAnswer(sql("""
Review Comment:
I updated the test. I added assertions to check for the expected shuffle
exchanges and added some notes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
