mnpw commented on PR #14083: URL: https://github.com/apache/datafusion/pull/14083#issuecomment-2585101517
@alamb for your consideration. I don't like that `datafusion-physical-optimizer` needs to use `datafusion` crate as a dev-dependency. This was required as `SanityChecker` tests were tightly coupled with the helper functions in `datafusion::physical_optimizer::test_utils`. Perhaps we can consider moving these helper functions somewhere outside, say, to `test-utils` crate? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
