alamb commented on code in PR #14083:
URL: https://github.com/apache/datafusion/pull/14083#discussion_r1916965668
##########
datafusion/physical-optimizer/Cargo.toml:
##########
@@ -36,10 +36,14 @@ recursive_protection = ["dep:recursive"]
[dependencies]
arrow = { workspace = true }
+arrow-schema = { workspace = true }
datafusion-common = { workspace = true, default-features = true }
datafusion-execution = { workspace = true }
+datafusion-expr = { workspace = true }
datafusion-expr-common = { workspace = true, default-features = true }
+datafusion-functions-aggregate = { workspace = true }
Review Comment:
I think we are trying very hard to avoid this dependency -- specifically we
are trying to avoid having the optimizer depend on any actual function
implementations
The separation ensures that there is no special treatment for provided
functions vs built in ones
I played around with this some morning and I found a way to remove it here:
- https://github.com/apache/datafusion/pull/14134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
