jayzhan211 commented on code in PR #13717:
URL: https://github.com/apache/datafusion/pull/13717#discussion_r1912362004


##########
datafusion/core/src/catalog_common/information_schema.rs:
##########
@@ -406,6 +406,7 @@ fn get_udf_args_and_return_types(
             .into_iter()
             .map(|arg_types| {
                 // only handle the function which implemented 
[`ScalarUDFImpl::return_type`] method
+                #[allow(deprecated)]

Review Comment:
   I found that we don't even need `args: Vec<Expr>`, what we need are 
`Vec<String>`.
   
   ```rust
   pub struct ReturnTypeArgs<'a> {
       pub arg_types: &'a [DataType],
       pub arguments: &'a [String],
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to