chenkovsky commented on PR #993: URL: https://github.com/apache/datafusion-python/pull/993#issuecomment-2588460451
> This is a massive amount of new code that will only serve to present additional overhead when developing. The internal API is not public. A decision was made in https://github.com/apache/datafusion-python/pull/750 to use Python wrapper classes as the method for public-facing type checking. internal api type annotation is not for user of this library，it's useful for developer of this library. automated tools can be used to gurarantee code quality. i annotated the intetnal api，then i can easily find several bugs via pyright. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
