chenkovsky commented on code in PR #993:
URL: https://github.com/apache/datafusion-python/pull/993#discussion_r1913948856
##########
python/datafusion/catalog.py:
##########
@@ -66,9 +66,10 @@ def __init__(self, table: df_internal.Table) -> None:
"""This constructor is not typically called by the end user."""
self.table = table
+ @property
Review Comment:
i checked the test，i think we should use @property， but previously we didnt
do wrapping somewhere， raw table is returned that's why test passed.
##########
python/datafusion/catalog.py:
##########
@@ -66,9 +66,10 @@ def __init__(self, table: df_internal.Table) -> None:
"""This constructor is not typically called by the end user."""
self.table = table
+ @property
Review Comment:
i checked the test，i think we should use @ property， but previously we didnt
do wrapping somewhere， raw table is returned that's why test passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
