erenavsarogullari commented on code in PR #1290:
URL: https://github.com/apache/datafusion-comet/pull/1290#discussion_r1917053881
##########
native/proto/src/proto/expr.proto:
##########
@@ -86,6 +86,7 @@ message Expr {
ArrayInsert array_insert = 59;
BinaryExpr array_contains = 60;
BinaryExpr array_remove = 61;
+ BinaryExpr array_join = 63;
Review Comment:
I have another PR for
[array_intersect](https://github.com/apache/datafusion-comet/pull/1271/files#diff-80c3ba0a1bf291317df58867a22e3f9abe681a16f7a8a9ec4959f744a0a2d509R89)
and it uses 62. I think `array_intersect` can go first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
