erenavsarogullari commented on PR #1290:
URL: 
https://github.com/apache/datafusion-comet/pull/1290#issuecomment-2601018854

   > I think the handling of the third argument (nullReplacement) is missing 
see: 
https://docs.databricks.com/en/sql/language-manual/functions/array_join.html#arguments.
 I think this will also require a new expression type in expr.proto
   
   Thanks - That is right both Spark and DataFusion supports optional 
`nullReplacement` and this requires new `ArrayJoin` Proto message.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to