alamb commented on code in PR #14134:
URL: https://github.com/apache/datafusion/pull/14134#discussion_r1920255614
##########
datafusion/expr/src/test/function_stub.rs:
##########
@@ -252,6 +252,10 @@ impl AggregateUDFImpl for Count {
Ok(DataType::Int64)
}
+ fn is_nullable(&self) -> bool {
Review Comment:
BTW this makes the count function stub match the actual count function which
is also not nullable
This was required to get the existing tests to pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
