alamb opened a new pull request, #1670: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1670
- Part of https://github.com/apache/datafusion-sqlparser-rs/issues/1597 When I tried to create the release tarball this time I got an error: ``` Running rat license checker on /Users/andrewlamb/Software/sqlparser-rs/dev/dist/apache-datafusion-sqlparser-rs-0.54.0-rc1/apache-datafusion-sqlparser-rs-0.54.0.tar.gz NOT APPROVED: sqlparser_bench/img/flamegraph.svg (apache-datafusion-sqlparser-rs-0.54.0/sqlparser_bench/img/flamegraph.svg): false 1 unapproved licences. Check rat report: rat.txt ``` I think this is because svg files are XML so the rat checker checks them for the apache license There is no reason to add the license explicitly I don't think so I propose adding to the exclude file I was able to use this change locally to make the `0.54.0` RC so there is no particular urgency for this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
