mbutrovich commented on code in PR #1329:
URL: https://github.com/apache/datafusion-comet/pull/1329#discussion_r1927309734
##########
native/core/src/execution/jni_api.rs:
##########
@@ -508,9 +505,6 @@ pub unsafe extern "system" fn
Java_org_apache_comet_Native_executePlan(
let next_item = exec_context.stream.as_mut().unwrap().next();
let poll_output = exec_context.runtime.block_on(async {
poll!(next_item) });
- // Update metrics
- update_metrics(&mut env, exec_context)?;
Review Comment:
I think checking a coarse-grained clock (i.e., `CLOCK_MONOTONIC_COARSE`) to
see if N seconds has elapsed to produce updated metrics would be a reasonable
compromise on performance impact vs. fresh metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
