mbutrovich commented on code in PR #1329:
URL: https://github.com/apache/datafusion-comet/pull/1329#discussion_r1945150669
##########
native/core/src/execution/jni_api.rs:
##########
@@ -233,11 +242,12 @@ pub unsafe extern "system" fn
Java_org_apache_comet_Native_createPlan(
stream: None,
runtime,
metrics,
+ metrics_update_interval,
+ metrics_last_update_time: Instant::now(),
Review Comment:
I ran `coarsetime`'s benchmark on my laptop:
```
coarsetime_now(): 126.93 M/s
coarsetime_recent(): 340.32 M/s
coarsetime_elapsed(): 142.64 M/s
coarsetime_since_recent(): 340.34 M/s
stdlib_now(): 51.37 M/s
stdlib_elapsed(): 42.42 M/s
```
I'm a bit stunned that Rust's stdlib doesn't provide a nice way to get
coarse time on its own, since the performance difference can be quite large and
a lot of tasks don't need nanosecond precision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
