Re: [PR] Fix DF 43 Regression: Coerce Various Scalar Func Args to String [datafusion]

[via GitHub]

shehabgamin commented on code in PR #14268:
URL: https://github.com/apache/datafusion/pull/14268#discussion_r1928535027


##########
datafusion/functions/src/string/ascii.rs:
##########
@@ -61,7 +64,15 @@ impl Default for AsciiFunc {
 impl AsciiFunc {
     pub fn new() -> Self {
         Self {
-            signature: Signature::string(1, Volatility::Immutable),
+            signature: Signature::one_of(
+                vec![
+                    TypeSignature::String(1),
+                    TypeSignature::Coercible(vec![TypeSignatureClass::Native(

Review Comment:
   That's what I initially did, but after testing on Sail, I discovered new 
test failures related to coercing input that's all String (e.g. `func(Utf8, 
Utf8View)`).
   
   The plan is to port all the relevant tests from Sail into this PR!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org