Re: [PR] Fix DF 43 Regression: Coerce Various Scalar Func Args to String [datafusion]

[via GitHub]

jayzhan211 commented on code in PR #14268:
URL: https://github.com/apache/datafusion/pull/14268#discussion_r1929387032


##########
datafusion/functions/src/string/ascii.rs:
##########
@@ -61,7 +64,15 @@ impl Default for AsciiFunc {
 impl AsciiFunc {
     pub fn new() -> Self {
         Self {
-            signature: Signature::string(1, Volatility::Immutable),
+            signature: Signature::one_of(
+                vec![
+                    TypeSignature::String(1),
+                    TypeSignature::Coercible(vec![TypeSignatureClass::Native(

Review Comment:
   The current design for coercion may still have room for improvement. It 
would be beneficial to represent the function signature in a simpler and more 
concise manner, rather than relying on complex combinations of multiple, 
similar signatures.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org