Sevenannn opened a new pull request, #14288:
URL: https://github.com/apache/datafusion/pull/14288

   ## Which issue does this PR close?
   
   NA
   
   ## Rationale for this change
   
   Some dialect doesn't support window frames in window function, for example, 
in dremio, window frame doesn't work with RANK, DENSE_RANK or ROW_NUMBER 
functions, and would cause error like will cause error like `ROW/RANGE not 
allowed with RANK, DENSE_RANK or ROW_NUMBER functions`.
   
   ## What changes are included in this PR?
   
   Include a method for Dialect determining whether the Dialect support window 
frame based on the window function name, start_bound, end_bound. When the 
window frame start_bound and end_bound indicates that no frame is specified in 
the original query, and the window function requires no window frame to 
function in the expected way, the window function will be unparsed as None in 
ast.
   ## Are these changes tested?
   
   Yes
   
   ## Are there any user-facing changes?
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to