kazuyukitanimura commented on code in PR #1341:
URL: https://github.com/apache/datafusion-comet/pull/1341#discussion_r1931214061
##########
native/spark-expr/src/math_funcs/round.rs:
##########
@@ -85,9 +85,10 @@ pub fn spark_round(
let (precision, scale) = get_precision_scale(data_type);
make_decimal_array(array, precision, scale, &f)
}
- DataType::Float32 | DataType::Float64 => {
- Ok(ColumnarValue::Array(round(&[Arc::clone(array)])?))
- }
+ DataType::Float32 | DataType::Float64 =>
Ok(ColumnarValue::Array(round(&[
Review Comment:
FYI round for float is disabled
https://github.com/apache/datafusion-comet/blob/main/spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala#L1739
BTW we should be able to use `point` instead of `args[1]`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
