alamb commented on issue #14256: URL: https://github.com/apache/datafusion/issues/14256#issuecomment-2622826545
> > After removing the WildcardOptions (by replacing it with an empty structure) I can see the build time drops. Removing the rule itself and the change in core doesn't help. It looks like the change to Expr is the root cause, though I don't know the reason... > > I wonder if the issue is that `WildCardOptions` is a large struct that is not `Box`ed -- so it means that every `Expr` needs to be large enough to hold it which maybe increased the size of all `Expr`s 🤔 🤔 it seems we have already Box'd it: https://github.com/apache/datafusion/blob/2797cf7221e5492f14157e461d8066f5223650ce/datafusion/expr/src/expr.rs#L316-L315 Let me see if I can find ways to make Expr smaller though -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
