viirya commented on code in PR #14392:
URL: https://github.com/apache/datafusion/pull/14392#discussion_r1938056200
##########
Cargo.toml:
##########
@@ -32,6 +32,7 @@ members = [
"datafusion/functions-aggregate-common",
"datafusion/functions-table",
"datafusion/functions-nested",
+ "datafusion/functions-spark",
"datafusion/functions-window",
"datafusion/functions-window-common",
Review Comment:
Hmm, it is good to add this crate. But I'm wondering that our other function
crates like `functions-nested` should also follow Spark behavior, right? So it
sounds like all these functions should be in `datafusion-functions-spark`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
