shehabgamin commented on code in PR #14392: URL: https://github.com/apache/datafusion/pull/14392#discussion_r1938420167
########## datafusion/spark/src/agg_funcs/avg.rs: ########## @@ -0,0 +1,344 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use arrow::compute::sum; +use arrow_array::{ + builder::PrimitiveBuilder, + cast::AsArray, + types::{Float64Type, Int64Type}, + Array, ArrayRef, ArrowNumericType, Int64Array, PrimitiveArray, +}; +use arrow_schema::{DataType, Field}; +use datafusion::logical_expr::{ + type_coercion::aggregates::avg_return_type, Accumulator, EmitTo, GroupsAccumulator, + Signature, +}; +use datafusion_common::{not_impl_err, Result, ScalarValue}; +use datafusion_physical_expr::expressions::format_state_name; +use std::{any::Any, sync::Arc}; + +use arrow_array::ArrowNativeTypeOp; +use datafusion_expr::function::{AccumulatorArgs, StateFieldsArgs}; +use datafusion_expr::Volatility::Immutable; +use datafusion_expr::{AggregateUDFImpl, ReversedUDAF}; +use DataType::*; + +/// AVG aggregate expression +#[derive(Debug, Clone)] +pub struct Avg { Review Comment: Subtle differences (e.g., `i32` instead of `i64`, `nullable`instead of `non-nullable`, `microseconds` instead of `nanoseconds`, etc.) between the DataFusion "default" implementation and the Spark implementation are going to be a common theme with many of these UDFs. @andygrove @alamb This is where having something like https://github.com/apache/datafusion/issues/14296#issuecomment-2614200125 would be useful. Otherwise we will always have to keep track of any changes made to the original DataFusion "default" implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
