blaginin commented on code in PR #14402: URL: https://github.com/apache/datafusion/pull/14402#discussion_r1938293787
########## datafusion/sqllogictest/test_files/group_by.slt: ########## @@ -3003,7 +3003,7 @@ SELECT FIRST_VALUE(amount ORDER BY ts ASC) AS fv1, LAST_VALUE(amount ORDER BY ts ASC) AS fv2 FROM sales_global ---- -30 100 +30 80 Review Comment: IMO, it actually makes more sense because that line has the same `ORDER BY` value but appears last in the table. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
