comphead commented on PR #14392: URL: https://github.com/apache/datafusion/pull/14392#issuecomment-2629508048
That is exactly what I was mentioning https://github.com/apache/datafusion/pull/14392#issuecomment-2628334890 not sure how to separate out functions with the same names. I think this crate and PR makes a lot of sense until the user wants a mixed implementation, another thing is the code is duplicated, so changes in base function may not be reflected in spark variant. @andygrove @alamb maybe we can do a conditional compilation on function level instead of separate crate? Sort of introduce a feature spark and have different implementations ``` #[cfg(spark)] fn to_timestamp() {} #![cfg(spark)] fn to_timestamp() {} ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
