alamb commented on code in PR #14371:
URL: https://github.com/apache/datafusion/pull/14371#discussion_r1942700622
##########
datafusion/common/src/error.rs:
##########
@@ -131,6 +131,10 @@ pub enum DataFusionError {
/// Errors from either mapping LogicalPlans to/from Substrait plans
/// or serializing/deserializing protobytes to Substrait plans
Substrait(String),
+
+ /// Errors for wrapping other errors.
Review Comment:
Thank you @getChan -- As DataFusionError is used all over the place and is
a very visible part of the API I was thinking it would be best if we can avoid
adding too many variants. However, after playing with some other options (like
deep cloning the error) I agree that this solution is the best.
to be consistent with the other variants which don't have a `Error` in their
name, I renamed this to `DataFusionError::Shared`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
