davisp opened a new issue, #14518: URL: https://github.com/apache/datafusion/issues/14518
### Describe the bug Just got caught by this. If you don't have `datafusion::common::Result` in scope as `Result` when using `config_namespace!`, rust-analyzer returns diagnostics for `enum takes 2 generic arguments but 1 generic argument was supplied`. I ended up having to `cargo expand` the module and paste it into an editor to figure out what it was complaining about. I'm pretty sure I just need to fully specify the `Result` type here: https://github.com/apache/datafusion/blob/304488d348ad2c952ce24f93064a81046155da79/datafusion/common/src/config.rs#L142 As in, just prefix it with `::datafusion::common::` on that line. ### To Reproduce ```rust use datafusion::common::config::{ConfigField, Visit}; use datafusion::common::config_namespace; use datafusion::common::error::_config_err; // This has to be uncommented to fix the compiler error. // use datafusion::common::Result; config_namespace! { /// Options for controlling TileDB specific optimizations pub struct ExampleOptions { /// Control whether TileDB will attempt to do predicate pushdown. /// Setting this to false will disable all predicate push down analysis /// and rely on DataFusion to filter returned data. Generally speaking, /// this should only be disabled when testing predicate pushdown /// logic. pub some_setting: String, default = String::new() } } ``` ### Expected behavior I would expect `config_namespace!` to work whether or not I have a specific identifier in scope. ### Additional context I'm more than happy to post a PR for this as long as someone Ok's the proposed solution (or can point me at a better approach). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
