alamb commented on PR #14224: URL: https://github.com/apache/datafusion/pull/14224#issuecomment-2639925962
Something else I noticed is the import paths for ParquetExec are gone (so I got a lot of compile errors about missing ParquetExec): ``` error[E0432]: unresolved import `datafusion::datasource::physical_plan::ParquetExec` --> iox_query/src/physical_optimizer/limits.rs:4:5 | 4 | use datafusion::datasource::physical_plan::ParquetExec; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `ParquetExec` in `datasource::physical_plan` | help: consider importing this struct instead | 4 | use datafusion::datasource::physical_plan::parquet::ParquetExec; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` Suggested action is reexport the file here ```diff --- a/datafusion/core/src/datasource/physical_plan/mod.rs +++ b/datafusion/core/src/datasource/physical_plan/mod.rs @@ -33,7 +33,7 @@ pub(crate) use self::json::plan_to_json; #[cfg(feature = "parquet")] pub use self::parquet::source::ParquetSource; #[cfg(feature = "parquet")] -pub use self::parquet::{ParquetFileMetrics, ParquetFileReaderFactory}; +pub use self::parquet::{ParquetFileMetrics, ParquetFileReaderFactory, ParquetExec}; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org