wForget commented on code in PR #1379:
URL: https://github.com/apache/datafusion-comet/pull/1379#discussion_r1946064632
##########
spark/src/main/scala/org/apache/spark/Plugins.scala:
##########
@@ -90,13 +96,19 @@ class CometDriverPlugin extends DriverPlugin with Logging
with ShimCometDriverPl
/**
* Whether we should override Spark memory configuration for Comet. This
only returns true when
- * Comet native execution is enabled and/or Comet shuffle is enabled
+ * Comet native execution is enabled and/or Comet shuffle is enabled and
Comet doesn't use
+ * unified memory manager.
*/
private def shouldOverrideMemoryConf(conf: SparkConf): Boolean = {
conf.getBoolean(CometConf.COMET_ENABLED.key, true) && (
- conf.getBoolean(CometConf.COMET_EXEC_SHUFFLE_ENABLED.key, false) ||
Review Comment:
The default value of this configuration has been changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
