wForget commented on code in PR #1379:
URL: https://github.com/apache/datafusion-comet/pull/1379#discussion_r1951883438
##########
spark/src/test/scala/org/apache/spark/CometPluginsSuite.scala:
##########
@@ -126,6 +126,8 @@ class CometPluginsNonOverrideSuite extends CometTestBase {
conf.set("spark.executor.memoryOverheadFactor", "0.5")
conf.set("spark.plugins", "org.apache.spark.CometPlugin")
conf.set("spark.comet.enabled", "true")
+ conf.set("spark.comet.exec.shuffle.enabled", "false")
Review Comment:
In this test case, it corresponds to the original judgment here. Since I
changed the default value, we need to add it.
https://github.com/apache/datafusion-comet/blob/f099e6e40aa18441c7882e5bffd9d6dfb10c6c19/spark/src/main/scala/org/apache/spark/Plugins.scala#L97
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
