parthchandra commented on code in PR #1386:
URL: https://github.com/apache/datafusion-comet/pull/1386#discussion_r1950904661
##########
native/core/src/execution/jni_api.rs:
##########
@@ -319,6 +320,7 @@ fn parse_memory_pool_config(
"greedy_global" =>
MemoryPoolConfig::new(MemoryPoolType::GreedyGlobal, pool_size),
"fair_spill" => MemoryPoolConfig::new(MemoryPoolType::FairSpill,
pool_size_per_task),
"greedy" => MemoryPoolConfig::new(MemoryPoolType::Greedy,
pool_size_per_task),
+ "unbounded" => MemoryPoolConfig::new(MemoryPoolType::Unbounded, 0),
Review Comment:
TBH, I don't know if it is ever a good idea to allow an unbounded memory
pool. It doesn't hurt to have the option, but under what conditions is this
choice useful?
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -504,8 +504,8 @@ object CometConf extends ShimCometConf {
.doc(
"The type of memory pool to be used for Comet native execution. " +
"Available memory pool types are 'greedy', 'fair_spill',
'greedy_task_shared', " +
- "'fair_spill_task_shared', 'greedy_global' and 'fair_spill_global'.
For off-heap " +
- "types are 'unified' and `fair_unified`.")
+ "'fair_spill_task_shared', 'greedy_global', 'fair_spill_global', and
`unbounded`. " +
Review Comment:
At this point there are so many options for memory pool that it is bound to
confuse users. Would it be a good idea to have a bit of documentation that
helps users decide what kind of memory pool to use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
