andygrove commented on code in PR #1386:
URL: https://github.com/apache/datafusion-comet/pull/1386#discussion_r1953180065


##########
native/core/src/execution/jni_api.rs:
##########
@@ -319,6 +320,7 @@ fn parse_memory_pool_config(
             "greedy_global" => 
MemoryPoolConfig::new(MemoryPoolType::GreedyGlobal, pool_size),
             "fair_spill" => MemoryPoolConfig::new(MemoryPoolType::FairSpill, 
pool_size_per_task),
             "greedy" => MemoryPoolConfig::new(MemoryPoolType::Greedy, 
pool_size_per_task),
+            "unbounded" => MemoryPoolConfig::new(MemoryPoolType::Unbounded, 0),

Review Comment:
   I see the value in having the unbounded tool for development testing 
purposes but not for end user use.
   
   I would like to use it to help with 
https://github.com/apache/datafusion-comet/issues/1315



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to