jayzhan211 commented on code in PR #14689:
URL: https://github.com/apache/datafusion/pull/14689#discussion_r1957604951
##########
datafusion/core/src/execution/context/csv.rs:
##########
@@ -116,11 +116,11 @@ mod tests {
assert_eq!(results.len(), 1);
let expected = [
- "+--------------+--------------+----------+",
- "| sum(test.c1) | sum(test.c2) | count(*) |",
- "+--------------+--------------+----------+",
- "| 10 | 110 | 20 |",
- "+--------------+--------------+----------+",
+ "+--------------+--------------+--------------+",
+ "| sum(test.c1) | sum(test.c2) | count_star() |",
Review Comment:
> In this case, it looks like we don't preserve COUNT(1).
Yes we don't. count(const_expr), count(), count(*) are all the same thing, I
don't think we need to preserve them all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
