Re: [PR] Remove CountWildcardRule in Analyzer and move the functionality in ExprPlanner, add `plan_aggregate` and `plan_window` to planner [datafusion]

[via GitHub]

jonahgao commented on code in PR #14689:
URL: https://github.com/apache/datafusion/pull/14689#discussion_r1962798687


##########
datafusion/functions-aggregate/src/count.rs:
##########
@@ -359,6 +547,15 @@ impl AggregateUDFImpl for Count {
     }
 }
 
+fn is_count_wildcard(args: &[Expr]) -> bool {
+    match args {
+        [] => true, // count()
+        // All const should be coerced to int64 or rejected by the signature
+        [Expr::Literal(ScalarValue::Int64(_))] => true, // count(1)

Review Comment:
   So `is_count_wildcard()` should reject it.
   It only has a problem in the display of logical plan.
   ![CleanShot 2025-02-20 at 11 10 
02@2x](https://github.com/user-attachments/assets/2a6894a2-d5bc-47fc-a170-9dcfefbd2fd2)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org