clflushopt opened a new pull request, #14735:
URL: https://github.com/apache/datafusion/pull/14735

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   - - Part of #3929 (see the recent followup discussion) and a follow up for 
#14688
   
   ## Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in 
the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your 
changes and offer better suggestions for fixes.  
   -->
   The goal of this change is to supplement the example in #14688 with a more 
useful example that demonstrates the current state of boundary analysis for 
`AND` conjunctions; we also explain and show that `OR` conjunctions are not 
currently supported.
   
   ## What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is 
sometimes worth providing a summary of the individual changes in this PR.
   -->
   In `datafusion-examples/examples/expr_api.rs` there is now a new function 
that explains data flow during boundary analysis and selectivity calculation 
for the expression `age > 18 and <= 25` with some comments to explain what
   the logic under the hood does.
   
   In a separate commit, we are also adding a brief explainer of the boundary 
analysis framework to the Query Optimizer section in the library guide. The 
goal is to have some supporting documentation that collects, summaries and 
distills
   the information currently documented in the different pull requests and the 
original design doc (see #3929).
   
   ## Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are 
they covered by existing tests)?
   -->
   The change re-uses parts of the API that are already covered by existing 
tests.
   
   ## Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   Yes, this introduces a new example.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to