onlyjackfrost commented on issue #14430:
URL: https://github.com/apache/datafusion/issues/14430#issuecomment-2677326478
Hi @eliaperantoni, just updating my progress.
I've implemented the diagnostic like this.
@eliaperantoni thanks for implementing the `try_from_sqlparser_span` in the
first place, I was struggling with how to get the span from the function.
```
.map_err(|e| {
let span =
Span::try_from_sqlparser_span(sql_parser_span);
let mut diagnostic =
Diagnostic::new_error(format!("Invalid function
'{name}'"), span);
diagnostic.add_note(
format!("possible function {}", suggested_func_name),
None,
);
e.with_diagnostic(diagnostic)
})
```
I'm trying to add test case in the `/sql/cases/diagnostic.rs` file... will
raise PR later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
